Add semester_id query to bdb and make student_contact unique for all semesters #3645
Conversation
falbru
commented
Oct 2, 2024
falbru
commented
- Add semester_id query to bdb
- make student_contact unique for all semesters
| class StudentCompanyContactSerializer(BasisModelSerializer): | ||
| class Meta: | ||
| model = StudentCompanyContact | ||
| fields = ("id", "company_id", "student_id", "semester_id") |
There was a problem hiding this comment.
Is the semester_id supposed to be the year? (In the example it's "1"?
There was a problem hiding this comment.
It's the ID of the Semester object
lego/apps/companies/views.py
Outdated
| def _list(self, request, *args, **kwargs): | ||
| semester_id = request.query_params.get('semester_id', None) | ||
|
|
||
| serializer = self.get_serializer(self.queryset, many=True, context={'semester_id': semester_id}) |
There was a problem hiding this comment.
Is there some way to just update the context (so we don't lose request and the other couple things passed down by default)?
There was a problem hiding this comment.
Good point! I'll look into it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3645 +/- ##
==========================================
+ Coverage 89.14% 89.16% +0.01%
==========================================
Files 684 685 +1
Lines 21537 21574 +37
==========================================
+ Hits 19200 19237 +37
Misses 2337 2337 ☔ View full report in Codecov by Sentry. |
|
I'll change the query paramter later. Kind of bored of this PR rn and want it merged |
